nimmo/nixos-config

Watch

Fork 0

refactor: narrow common and desktop baselines #119

Merged

nimmo merged 1 commit from feat/narrow-baselines into main

2026-07-28 11:37:46 +01:00

nimmo commented

2026-07-28 11:31:20 +01:00

Owner

Closes #114

Make host composition boundaries explicit without changing current host behavior. Keep universal defaults, fleet monitoring, and the service-failure option provider in common/base; move Backrest into an explicit backup profile, compose AI support modules with ai-agents, and import Vega-only services from Vega. Document the desktop-support composition boundary.

Validation:

nix fmt -- --ci
nix flake check
nix build .#nixosConfigurations.electra.config.system.build.toplevel --no-link
nix build .#nixosConfigurations.vega.config.system.build.toplevel --no-link

Closes #114 Make host composition boundaries explicit without changing current host behavior. Keep universal defaults, fleet monitoring, and the service-failure option provider in common/base; move Backrest into an explicit backup profile, compose AI support modules with ai-agents, and import Vega-only services from Vega. Document the desktop-support composition boundary. Validation: - nix fmt -- --ci - nix flake check - nix build .#nixosConfigurations.electra.config.system.build.toplevel --no-link - nix build .#nixosConfigurations.vega.config.system.build.toplevel --no-link

nimmo added this to the Configuration Architecture Hygiene milestone

2026-07-28 11:31:20 +01:00

nimmo added 1 commit

2026-07-28 11:31:21 +01:00

refactor: narrow common and desktop baselines

Build and Push Attic Cache / test (pull_request) Successful in 39s

Details

Build and Push Attic Cache / build (pull_request) Has been skipped

Details

AI pull-request review / review (pull_request) Successful in 3m12s

Details

b7ae06311d

nimmo commented

2026-07-28 11:34:36 +01:00

Author

Owner

Automated code review

Reviewed commit: b7ae06311d6c5c5e1bf247f6c1cc1b7f7dc09380

Verdict: Ready to merge

No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory.

Overall assessment

The pull request successfully narrows the common baseline by extracting profile-scoped and host-specific services from modules/common/base.nix into explicit composition points (profiles/backup.nix, profiles/ai-agents.nix, server/base.nix, and hosts/vega/default.nix). Documentation in README.md is updated to reflect the new architectural boundaries. The changes maintain functional parity while enforcing a stricter separation of concerns.

Blocking findings

None.

Important findings

None.

Suggestions

None.

Tests and validation

No configured deterministic checks.

Questions

Does modules/server/base.nix intentionally omit modules/common/base.nix, or does it rely on host-level imports to receive universal defaults such as locale, Nix settings, and sops-nix configuration?

Review limitations

Review is limited to the provided diff; full verification of transitive module dependencies and evaluation outcomes requires access to complete host composition files and flake check output.

Diff coverage

README.md: reviewed — included in a context-limited batch
hosts/vega/default.nix: reviewed — included in a context-limited batch
modules/common/base.nix: reviewed — included in a context-limited batch
modules/desktop/environment.nix: reviewed — included in a context-limited batch
modules/profiles/ai-agents.nix: reviewed — included in a context-limited batch
modules/profiles/backup.nix: reviewed — included in a context-limited batch
modules/profiles/gui.nix: reviewed — included in a context-limited batch
modules/server/base.nix: reviewed — included in a context-limited batch

Review metadata

Reviewer: forgejo-ai-review v1
Model: qwen3.6:35b-a3b-q8_0
Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md
Commits considered: 1
Previous automated review: none found
Findings: 0

## Automated code review Reviewed commit: `b7ae06311d6c5c5e1bf247f6c1cc1b7f7dc09380` ## Verdict: Ready to merge No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory. ### Overall assessment The pull request successfully narrows the common baseline by extracting profile-scoped and host-specific services from modules/common/base.nix into explicit composition points (profiles/backup.nix, profiles/ai-agents.nix, server/base.nix, and hosts/vega/default.nix). Documentation in README.md is updated to reflect the new architectural boundaries. The changes maintain functional parity while enforcing a stricter separation of concerns. ### Blocking findings None. ### Important findings None. ### Suggestions None. ### Tests and validation - No configured deterministic checks. ### Questions - Does modules/server/base.nix intentionally omit modules/common/base.nix, or does it rely on host-level imports to receive universal defaults such as locale, Nix settings, and sops-nix configuration? ### Review limitations - Review is limited to the provided diff; full verification of transitive module dependencies and evaluation outcomes requires access to complete host composition files and flake check output. ### Diff coverage - `README.md`: **reviewed** — included in a context-limited batch - `hosts/vega/default.nix`: **reviewed** — included in a context-limited batch - `modules/common/base.nix`: **reviewed** — included in a context-limited batch - `modules/desktop/environment.nix`: **reviewed** — included in a context-limited batch - `modules/profiles/ai-agents.nix`: **reviewed** — included in a context-limited batch - `modules/profiles/backup.nix`: **reviewed** — included in a context-limited batch - `modules/profiles/gui.nix`: **reviewed** — included in a context-limited batch - `modules/server/base.nix`: **reviewed** — included in a context-limited batch <details><summary>Review metadata</summary> - Reviewer: forgejo-ai-review v1 - Model: qwen3.6:35b-a3b-q8_0 - Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md - Commits considered: 1 - Previous automated review: none found - Findings: 0 </details>

nimmo merged commit 93988e4659 into main

2026-07-28 11:37:46 +01:00

nimmo deleted branch feat/narrow-baselines

2026-07-28 11:37:47 +01:00

nimmo referenced this pull request from a commit

2026-07-28 11:37:47 +01:00

Merge pull request 'refactor: narrow common and desktop baselines' (#119) from feat/narrow-baselines into main