nimmo/nixos-config

Watch

Fork 0

refactor(hosts): derive shared policy from host facts #162

Merged

nimmo merged 1 commit from issue-17-host-facts into main

2026-08-12 11:22:54 +01:00

nimmo commented

2026-08-11 22:06:44 +01:00

Owner

Summary

add explicit nixosConfig.host.gpu.vendors metadata and show it in just inventory
install llmfit only on hosts declaring a local GPU
derive Home Manager server policy from the existing nixosConfig.host.role
align the Proxmox VM location metadata and document the inventory schema

Decision

Refs #17. This deliberately does not introduce nixosConfig.hostClass: the existing host.role is the durable shared classification required by Home Manager, while gpu.vendors models a separate hardware capability. The result remains explicit and avoids hidden profile selection.

Validation

nix fmt
nix flake check
just inventory
evaluated llmfit policy: enabled only for Electra and Lyra

Deployment evidence still required

Canary a role-bearing host and confirm its Home Manager activation still applies the expected headless/desktop policy. Do not close #17 until that evidence is recorded.

## Summary - add explicit `nixosConfig.host.gpu.vendors` metadata and show it in `just inventory` - install `llmfit` only on hosts declaring a local GPU - derive Home Manager server policy from the existing `nixosConfig.host.role` - align the Proxmox VM location metadata and document the inventory schema ## Decision Refs #17. This deliberately does **not** introduce `nixosConfig.hostClass`: the existing `host.role` is the durable shared classification required by Home Manager, while `gpu.vendors` models a separate hardware capability. The result remains explicit and avoids hidden profile selection. ## Validation - `nix fmt` - `nix flake check` - `just inventory` - evaluated `llmfit` policy: enabled only for Electra and Lyra ## Deployment evidence still required Canary a role-bearing host and confirm its Home Manager activation still applies the expected headless/desktop policy. Do not close #17 until that evidence is recorded.

nimmo added this to the Host Facts Refactor milestone

2026-08-11 22:06:44 +01:00

nimmo added 1 commit

2026-08-11 22:06:44 +01:00

refactor(hosts): derive shared policy from host facts

Build and Push Attic Cache / test (pull_request) Successful in 1m14s

Details

Build and Push Attic Cache / build (pull_request) Has been skipped

Details

Build and Push Attic Cache / pin-lifecycle (pull_request) Has been skipped

Details

Build and Push Attic Cache / remediate (pull_request) Has been skipped

Details

AI pull-request review / review (pull_request) Successful in 3m15s

Details

614937a16e

nimmo commented

2026-08-11 22:16:11 +01:00

Author

Owner

Automated-review status: ai-review.yml ran but failed before posting any findings because its Ollama response parser received malformed JSON (Expecting ":" delimiter). The normal PR workflow completed successfully. This is reviewer infrastructure failure, not feedback against the change; the branch remains validated with nix flake check, just inventory, and the targeted llmfit policy evaluation. A Forgejo API rerun is not available, so no unrelated branch change has been made.

Automated-review status: `ai-review.yml` ran but failed before posting any findings because its Ollama response parser received malformed JSON (`Expecting ":" delimiter`). The normal PR workflow completed successfully. This is reviewer infrastructure failure, not feedback against the change; the branch remains validated with `nix flake check`, `just inventory`, and the targeted `llmfit` policy evaluation. A Forgejo API rerun is not available, so no unrelated branch change has been made.

nimmo commented

2026-08-11 22:42:56 +01:00

Author

Owner

Automated code review

Reviewed commit: 614937a16ec270ae95cae74008952c48f98f8980

Verdict: Ready to merge

No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory.

Overall assessment

Refactors host policy by introducing explicit gpu.vendors metadata, derives Home Manager's isServer flag from nixosConfig.host.role, moves conditional llmfit installation to a shared module, updates inventory tooling and documentation accordingly. Changes are scoped correctly and align with stated goals.

Blocking findings

None.

Important findings

None.

Suggestions

None.

Tests and validation

No configured deterministic checks.

Questions

None.

Review limitations

Review is based solely on the provided static diff; actual Nix evaluation, nix flake check output, and live deployment behavior were not executed.
Cannot verify runtime Home Manager policy derivation or GPU capability detection without access to the build environment or target hosts.

Diff coverage

README.md: reviewed — included in a context-limited batch
flake.nix: reviewed — included in a context-limited batch
hosts/chaos/default.nix: reviewed — included in a context-limited batch
hosts/cosmos/default.nix: reviewed — included in a context-limited batch
hosts/electra/default.nix: reviewed — included in a context-limited batch
hosts/lyra/default.nix: reviewed — included in a context-limited batch
justfiles/hosts.just: reviewed — included in a context-limited batch
modules/common/default-config.nix: reviewed — included in a context-limited batch
modules/common/system.nix: reviewed — included in a context-limited batch

Review metadata

Reviewer: forgejo-ai-review v1
Model: qwen3.6:35b-a3b-q8_0
Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md
Commits considered: 1
Previous automated review: none found
Findings: 0

## Automated code review Reviewed commit: `614937a16ec270ae95cae74008952c48f98f8980` ## Verdict: Ready to merge No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory. ### Overall assessment Refactors host policy by introducing explicit `gpu.vendors` metadata, derives Home Manager's `isServer` flag from `nixosConfig.host.role`, moves conditional `llmfit` installation to a shared module, updates inventory tooling and documentation accordingly. Changes are scoped correctly and align with stated goals. ### Blocking findings None. ### Important findings None. ### Suggestions None. ### Tests and validation - No configured deterministic checks. ### Questions None. ### Review limitations - Review is based solely on the provided static diff; actual Nix evaluation, `nix flake check` output, and live deployment behavior were not executed. - Cannot verify runtime Home Manager policy derivation or GPU capability detection without access to the build environment or target hosts. ### Diff coverage - `README.md`: **reviewed** — included in a context-limited batch - `flake.nix`: **reviewed** — included in a context-limited batch - `hosts/chaos/default.nix`: **reviewed** — included in a context-limited batch - `hosts/cosmos/default.nix`: **reviewed** — included in a context-limited batch - `hosts/electra/default.nix`: **reviewed** — included in a context-limited batch - `hosts/lyra/default.nix`: **reviewed** — included in a context-limited batch - `justfiles/hosts.just`: **reviewed** — included in a context-limited batch - `modules/common/default-config.nix`: **reviewed** — included in a context-limited batch - `modules/common/system.nix`: **reviewed** — included in a context-limited batch <details><summary>Review metadata</summary> - Reviewer: forgejo-ai-review v1 - Model: qwen3.6:35b-a3b-q8_0 - Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md - Commits considered: 1 - Previous automated review: none found - Findings: 0 </details>

nimmo merged commit 618ec60496 into main

2026-08-12 11:22:54 +01:00

nimmo referenced this pull request from a commit

2026-08-12 11:22:55 +01:00

Merge pull request 'refactor(hosts): derive shared policy from host facts' (#162) from issue-17-host-facts into main

nimmo deleted branch issue-17-host-facts

2026-08-12 11:22:55 +01:00