Advance Pi inputs through the validated auto-update pipeline #213

Merged

nimmo merged 3 commits from fix/auto-update-pi-inputs into main 2026-09-10 00:11:25 +01:00

Conversation 3 Commits 3 Files changed 3 +34 -13

nimmo commented 2026-09-09 23:40:46 +01:00

Owner

Copy link

References #212.

Pi and pi-ollama are now root inputs. The pi-agent flake follows them and the shared nixpkgs input, so the existing pi-agent policy group updates and validates all three together on Electra, Lena, Vega, and Lyra. The lock advances pi.nix from 92c057264e847c4676a80a5d57e968b5d25828a6 to f41e1136297ccd039ead5131739da85d0ac4a77c.

Validation: nix fmt; focused auto-update policy evaluation; nix flake check.

References #212. Pi and pi-ollama are now root inputs. The pi-agent flake follows them and the shared nixpkgs input, so the existing pi-agent policy group updates and validates all three together on Electra, Lena, Vega, and Lyra. The lock advances pi.nix from 92c057264e847c4676a80a5d57e968b5d25828a6 to f41e1136297ccd039ead5131739da85d0ac4a77c. Validation: nix fmt; focused auto-update policy evaluation; nix flake check.

nimmo added this to the Automated Update Remediation milestone 2026-09-09 23:40:46 +01:00

nimmo added the

project:auto-update-remediation

service:auto-update

labels 2026-09-09 23:40:46 +01:00

nimmo added 1 commit 2026-09-09 23:40:48 +01:00

fix(auto-update): advance Pi inputs with validated updates e353e60c8f

nimmo commented 2026-09-09 23:42:00 +01:00

Author

Owner

Copy link

Automated code review

Reviewed commit: 036ca21e76faea7499f21817e43442561415c784

Verdict: Ready to merge

No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory.

Overall assessment

The PR promotes pi and pi-ollama to root flake inputs and updates the pi-agent auto-update policy to include them. This ensures atomic updates for the Pi wrapper, agent, and Ollama extension. The changes are consistent with the provided diff and human replies.

Blocking findings

None.

Important findings

None.

Suggestions

None.

Tests and validation

• No configured deterministic checks.

Questions

• The diff shows pi-ollama is added as a root input with flake = false. The human reply confirms this is intentional to preserve the raw-source contract. Is there any risk that future updates to pi.nix might change how it exposes or expects the Ollama extension, potentially breaking the --extension ${piOllama}/src/index.ts invocation in pi-agent?

Review limitations

• I cannot verify the runtime compatibility of the pi-ollama source with the current pi-agent version beyond static analysis of the diff.
• I rely on the provided validation evidence (nix flake check) and cannot execute it myself.

Diff coverage

• flake.lock: reviewed — included in a context-limited batch
• flake.nix: reviewed — included in a context-limited batch
• lib/auto-update-policy.nix: reviewed — included in a context-limited batch

Review metadata

• Reviewer: forgejo-ai-review v1
• Model: qwen3.6:35b-a3b-q8_0
• Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md
• Commits considered: 3
• Previous automated review: updated
• Findings: 0

<!-- forgejo-ai-review:v1 --> ## Automated code review Reviewed commit: `036ca21e76faea7499f21817e43442561415c784` ## Verdict: Ready to merge No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory. ### Overall assessment The PR promotes `pi` and `pi-ollama` to root flake inputs and updates the `pi-agent` auto-update policy to include them. This ensures atomic updates for the Pi wrapper, agent, and Ollama extension. The changes are consistent with the provided diff and human replies. ### Blocking findings None. ### Important findings None. ### Suggestions None. ### Tests and validation - No configured deterministic checks. ### Questions - The diff shows `pi-ollama` is added as a root input with `flake = false`. The human reply confirms this is intentional to preserve the raw-source contract. Is there any risk that future updates to `pi.nix` might change how it exposes or expects the Ollama extension, potentially breaking the `--extension ${piOllama}/src/index.ts` invocation in `pi-agent`? ### Review limitations - I cannot verify the runtime compatibility of the `pi-ollama` source with the current `pi-agent` version beyond static analysis of the diff. - I rely on the provided validation evidence (`nix flake check`) and cannot execute it myself. ### Diff coverage - `flake.lock`: **reviewed** — included in a context-limited batch - `flake.nix`: **reviewed** — included in a context-limited batch - `lib/auto-update-policy.nix`: **reviewed** — included in a context-limited batch <details><summary>Review metadata</summary> - Reviewer: forgejo-ai-review v1 - Model: qwen3.6:35b-a3b-q8_0 - Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md - Commits considered: 3 - Previous automated review: updated - Findings: 0 </details>

nimmo commented 2026-09-09 23:53:41 +01:00

Author

Owner

Copy link

Follow-up on the automated-review questions:

pi-ollama is intentionally a root flake = false input. The updater does not inspect input outputs or assume locked.flake = true; its group helper invokes nix flake update "$input" for each policy entry. The exact nix flake update pi-ollama operation succeeded while refreshing this branch’s lock, and the resulting root lock node is valid.

pi-agent now follows the root pi, pi-ollama, and shared nixpkgs nodes, so the group advances and validates all three atomically. nix flake check evaluated electra, lena, vega, and lyra successfully; their modules receive inputs through specialArgs and accept the attribute set without strict argument matching.

Follow-up on the automated-review questions: `pi-ollama` is intentionally a root `flake = false` input. The updater does not inspect input outputs or assume `locked.flake = true`; its group helper invokes `nix flake update "$input"` for each policy entry. The exact `nix flake update pi-ollama` operation succeeded while refreshing this branch’s lock, and the resulting root lock node is valid. `pi-agent` now follows the root `pi`, `pi-ollama`, and shared `nixpkgs` nodes, so the group advances and validates all three atomically. `nix flake check` evaluated electra, lena, vega, and lyra successfully; their modules receive `inputs` through `specialArgs` and accept the attribute set without strict argument matching.

nimmo added 1 commit 2026-09-09 23:56:17 +01:00

docs(auto-update): clarify raw Pi extension updates 84f56e023d

nimmo added 1 commit 2026-09-10 00:09:09 +01:00

docs(auto-update): document Pi extension input contract 036ca21e76

nimmo commented 2026-09-10 00:09:13 +01:00

Author

Owner

Copy link

Verified against the restored pinned pi-agent source at 628e67210a6dfaab977f9571b35f99cc0706cf23: its flake.nix declares pi-ollama = { flake = false; }, binds piOllama = inputs.pi-ollama, and invokes Pi with --extension ${piOllama}/src/index.ts. The root input therefore preserves the exact intended raw-source contract; it does not supply a flake output.

Verified against the restored pinned pi-agent source at `628e67210a6dfaab977f9571b35f99cc0706cf23`: its `flake.nix` declares `pi-ollama = { flake = false; }`, binds `piOllama = inputs.pi-ollama`, and invokes Pi with `--extension ${piOllama}/src/index.ts`. The root input therefore preserves the exact intended raw-source contract; it does not supply a flake output.

nimmo merged commit 15d24e2cdc into main 2026-09-10 00:11:25 +01:00

nimmo referenced this pull request from a commit 2026-09-10 00:11:25 +01:00

Merge pull request 'Advance Pi inputs through the validated auto-update pipeline' (#213) from fix/auto-update-pi-inputs into main

nimmo deleted branch fix/auto-update-pi-inputs 2026-09-10 00:11:26 +01:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:authentication

Issues related to authentication area

  

area:flake-utilities

Issues related to flake utilities area

  

area:performance

Issues related to performance area

  

area:tbd

Area to be determined

  

host:chaos

Issues specific to the chaos host.

  

host:electra

Issues specific to the electra host.

  

host:fleet

Issues that span multiple hosts or the fleet as a whole.

  

host:lyra

Issues specific to the lyra host.

  

host:nova

Issues specific to the nova host.

  

host:vega

Issues specific to the vega host.

  

investigation

Issue is an investigation task

  

phase:cutover

The service cutover execution phase.

  

phase:deploy

  

phase:mcp

  

phase:module

  

phase:packaging

  

phase:prep

Preparation and preflight work before service cutover.

  

phase:validation

Post-cutover validation and rollback-window work.

  

priority:high

High priority issue

  

priority:medium

Medium priority issue

  

project:attic-postgres-lyra-rollout

Issues in the Attic PostgreSQL migration and Lyra rollout workstream.

  

project:auto-update-reliability

Work arising from the automated update reliability review.

  

project:auto-update-remediation

Guarded Nova-assisted diagnosis and remediation of failed automated updates.

  

project:declarative-purity-cleanup

Issues in the declarative purity cleanup workstream.

  

project:external-review

Review of external configurations for ideas and improvements

  

project:fleet-boundary-cleanup

Maintainability work that clarifies fleet configuration and automation boundaries.

  

project:host-facts-refactor

Issues in the host facts refactor workstream.

  

project:lyra-nixos-deploy

Issues in the Lyra NixOS deployment workstream.

  

project:lyra-service-stack-migration

Issues in the lyra service stack migration workstream.

  

project:nebula-mesh-network

Issues in the Nebula mesh network workstream.

  

project:nixos-build-deployment-pipeline

Issues in the NixOS Build & Deployment Pipeline workstream.

  

project:security-hardening

Work belonging to the Security Hardening milestone

  

project:service-stack-migration

Issues in the service stack migration workstream.

  

project:vega-sillytavern-cutover

Issues in the Vega SillyTavern cutover workstream.

  

project:wiki-rebuild

Re-found the repository wiki as the fleet's curated knowledge architecture.

  

repo:numtide/flake-utils

Issues related to numtide/flake-utils repository

  

repo:numtide/nix-auth

Issues related to numtide/nix-auth repository

  

repo:numtide/nixos-passthru-cache

Issues related to numtide/nixos-passthru-cache repository

  

repo:numtide/nix-relay

Issues related to numtide/nix-relay repository

  

service:auto-update

NixOS flake update, cache build, and consumer deployment automation.

  

service:mem0

  

service:nix

Issues concerning Nix build, store, cache, or deployment infrastructure.

  

service:sillytavern

Issues related to the SillyTavern service.

  

service:slskd

Soulseek daemon (slskd) work.

  

service:synthseek

Synthseek music discovery/library manager work.

No labels

area:authentication

area:flake-utilities

area:performance

area:tbd

host:chaos

host:electra

host:fleet

host:lyra

host:nova

host:vega

investigation

phase:cutover

phase:deploy

phase:mcp

phase:module

phase:packaging

phase:prep

phase:validation

priority:high

priority:medium

project:attic-postgres-lyra-rollout

project:auto-update-reliability

project:auto-update-remediation

project:declarative-purity-cleanup

project:external-review

project:fleet-boundary-cleanup

project:host-facts-refactor

project:lyra-nixos-deploy

project:lyra-service-stack-migration

project:nebula-mesh-network

project:nixos-build-deployment-pipeline

project:security-hardening

project:service-stack-migration

project:vega-sillytavern-cutover

project:wiki-rebuild

repo:numtide/flake-utils

repo:numtide/nix-auth

repo:numtide/nixos-passthru-cache

repo:numtide/nix-relay

service:auto-update

service:mem0

service:nix

service:sillytavern

service:slskd

service:synthseek

Milestone

Clear milestone

No items

No milestone

Automated Update Remediation

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

nimmo/nixos-config!213

No description provided.