nimmo/nixos-config

Watch

Fork 0

Remove Bitwarden desktop and insecure Electron 39 allowance #84

Merged

nimmo merged 1 commit from remove-bitwarden-desktop into main

2026-07-21 20:10:24 +01:00

nimmo commented

2026-07-21 19:57:57 +01:00

Owner

Summary

remove the Bitwarden desktop package from desktop hosts
remove its sandbox-test override
remove the explicit Electron 39 insecure-package allowance

The Bitwarden browser extension remains configured.

Validation

nix flake check

## Summary - remove the Bitwarden desktop package from desktop hosts - remove its sandbox-test override - remove the explicit Electron 39 insecure-package allowance The Bitwarden browser extension remains configured. ## Validation - `nix flake check`

nimmo added 1 commit

2026-07-21 19:57:57 +01:00

chore: remove Bitwarden desktop package

AI pull-request review / review (pull_request) Successful in 3m32s

Details

Build and Push Attic Cache / test (pull_request) Successful in 41s

Details

Build and Push Attic Cache / build (pull_request) Has been skipped

Details

6d05ff4896

nimmo commented

2026-07-21 20:01:30 +01:00

Author

Owner

Automated code review

Reviewed commit: 6d05ff489673f1db741915dd5a2dde2d1db9fa89

Verdict: Ready to merge

No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory.

Overall assessment

The diff removes bitwarden-desktop from the desktop applications list, along with its associated insecure Electron 39 package allowance and a test-disabling overlay. The changes are self-contained and correctly eliminate dead configuration and an explicit exception for an EOL Electron version.

Blocking findings

None.

Important findings

None.

Suggestions

None.

Tests and validation

nix-flake-check: success

Questions

Confirm whether any other Nix modules, user profiles, or flake inputs explicitly depend on bitwarden-desktop or require the removed electron-39.8.10 allowance, as this modifies a global nixpkgs.config setting.

Review limitations

Analysis is strictly limited to the provided diff for modules/desktop/apps.nix. Cross-module dependency verification, build validation via nix flake check, and runtime behavior were not executed.

Diff coverage

modules/desktop/apps.nix: reviewed — included in a context-limited batch

Review metadata

Reviewer: forgejo-ai-review v1
Model: qwen3.6:35b-a3b-q8_0
Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md
Commits considered: 1
Previous automated review: none found
Findings: 0

## Automated code review Reviewed commit: `6d05ff489673f1db741915dd5a2dde2d1db9fa89` ## Verdict: Ready to merge No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory. ### Overall assessment The diff removes `bitwarden-desktop` from the desktop applications list, along with its associated insecure Electron 39 package allowance and a test-disabling overlay. The changes are self-contained and correctly eliminate dead configuration and an explicit exception for an EOL Electron version. ### Blocking findings None. ### Important findings None. ### Suggestions None. ### Tests and validation - nix-flake-check: **success** ### Questions - Confirm whether any other Nix modules, user profiles, or flake inputs explicitly depend on `bitwarden-desktop` or require the removed `electron-39.8.10` allowance, as this modifies a global `nixpkgs.config` setting. ### Review limitations - Analysis is strictly limited to the provided diff for `modules/desktop/apps.nix`. Cross-module dependency verification, build validation via `nix flake check`, and runtime behavior were not executed. ### Diff coverage - `modules/desktop/apps.nix`: **reviewed** — included in a context-limited batch <details><summary>Review metadata</summary> - Reviewer: forgejo-ai-review v1 - Model: qwen3.6:35b-a3b-q8_0 - Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md - Commits considered: 1 - Previous automated review: none found - Findings: 0 </details>

nimmo merged commit dd0e485d67 into main

2026-07-21 20:10:24 +01:00

nimmo deleted branch remove-bitwarden-desktop

2026-07-21 20:10:24 +01:00

nimmo referenced this pull request from a commit

2026-07-21 20:10:25 +01:00

Merge pull request 'Remove Bitwarden desktop and insecure Electron 39 allowance' (#84) from remove-bitwarden-desktop into main