nimmo/nixos-config

Watch

Fork 0

Use regular unstable for Electra and avoid source Electron builds #85

Merged

nimmo merged 2 commits from electra-regular-unstable into main

2026-07-21 21:05:04 +01:00

nimmo commented

2026-07-21 20:47:12 +01:00

Owner

Summary

move Electra from nixos-unstable-small to the shared regular unstable package set
remove the now-unused unstable-small flake input and its update-policy group
make Element Desktop use Nixpkgs’ hash-pinned electron_42-bin, avoiding Chromium-scale electron-unwrapped source builds

The binary Electron archive remains pinned by the flake’s Nixpkgs revision; only source compilation is avoided.

Validation

nix flake check
./tests/auto-update-regressions.sh
targeted build of Element Desktop with electron_42-bin

## Summary - move Electra from `nixos-unstable-small` to the shared regular unstable package set - remove the now-unused unstable-small flake input and its update-policy group - make Element Desktop use Nixpkgs’ hash-pinned `electron_42-bin`, avoiding Chromium-scale `electron-unwrapped` source builds The binary Electron archive remains pinned by the flake’s Nixpkgs revision; only source compilation is avoided. ## Validation - `nix flake check` - `./tests/auto-update-regressions.sh` - targeted build of Element Desktop with `electron_42-bin`

nimmo added 1 commit

2026-07-21 20:47:13 +01:00

perf: use regular unstable for Electra

Build and Push Attic Cache / test (pull_request) Successful in 35s

Details

AI pull-request review / review (pull_request) Successful in 3m11s

Details

Build and Push Attic Cache / build (pull_request) Has been skipped

Details

460af317a3

nimmo commented

2026-07-21 20:50:26 +01:00

Author

Owner

Automated code review

Reviewed commit: 3e267666980bf2f76c6086099e0c99ddd741a2e0

Verdict: Ready to merge

No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory.

Overall assessment

The pull request cleanly migrates the Electra host from nixos-unstable-small to the shared unstable channel, removes the corresponding flake input and auto-update policy group, updates documentation, and switches Element Desktop to a pre-built Electron binary. Regression test expectations are adjusted consistently to reflect the removed policy group.

Blocking findings

None.

Important findings

None.

Suggestions

Verify electron_42-bin availability for target architecture (modules/desktop/apps.nix:34; high confidence)
(element-desktop.override { electron_42 = pkgs.electron_42-bin; })
Impact: Switching to a pre-built Electron binary avoids local compilation but depends on the package being available and ABI-compatible with Electra's target architecture.
Suggested fix: Confirm that electron_42-bin is built and available for Electra's architecture in the current unstable channel before merging.

Tests and validation

nix-flake-check: success

Questions

Does the shift to the regular unstable channel introduce any package version changes for Electra that could affect existing desktop workflows or specialisation configurations?

Review limitations

Review is limited to the provided diff and documentation; runtime behavior of Element Desktop with the binary Electron archive was not observed.
The nix flake check result confirms evaluation success but does not guarantee full host-specific specialisation validation.

Diff coverage

README.md: reviewed — included in a context-limited batch
flake.lock: reviewed — included in a context-limited batch
flake.nix: reviewed — included in a context-limited batch
lib/auto-update-policy.nix: reviewed — included in a context-limited batch
modules/desktop/apps.nix: reviewed — included in a context-limited batch
tests/auto-update-regressions.sh: reviewed — included in a context-limited batch

Review metadata

Reviewer: forgejo-ai-review v1
Model: qwen3.6:35b-a3b-q8_0
Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md
Commits considered: 2
Previous automated review: updated
Findings: 1

## Automated code review Reviewed commit: `3e267666980bf2f76c6086099e0c99ddd741a2e0` ## Verdict: Ready to merge No blocking or important findings were retained, and deterministic checks passed. Suggestions remain advisory. ### Overall assessment The pull request cleanly migrates the Electra host from `nixos-unstable-small` to the shared `unstable` channel, removes the corresponding flake input and auto-update policy group, updates documentation, and switches Element Desktop to a pre-built Electron binary. Regression test expectations are adjusted consistently to reflect the removed policy group. ### Blocking findings None. ### Important findings None. ### Suggestions - **Verify `electron_42-bin` availability for target architecture** (modules/desktop/apps.nix:34; high confidence) (element-desktop.override { electron_42 = pkgs.electron_42-bin; }) Impact: Switching to a pre-built Electron binary avoids local compilation but depends on the package being available and ABI-compatible with Electra's target architecture. Suggested fix: Confirm that `electron_42-bin` is built and available for Electra's architecture in the current `unstable` channel before merging. ### Tests and validation - nix-flake-check: **success** ### Questions - Does the shift to the regular `unstable` channel introduce any package version changes for Electra that could affect existing desktop workflows or specialisation configurations? ### Review limitations - Review is limited to the provided diff and documentation; runtime behavior of Element Desktop with the binary Electron archive was not observed. - The `nix flake check` result confirms evaluation success but does not guarantee full host-specific specialisation validation. ### Diff coverage - `README.md`: **reviewed** — included in a context-limited batch - `flake.lock`: **reviewed** — included in a context-limited batch - `flake.nix`: **reviewed** — included in a context-limited batch - `lib/auto-update-policy.nix`: **reviewed** — included in a context-limited batch - `modules/desktop/apps.nix`: **reviewed** — included in a context-limited batch - `tests/auto-update-regressions.sh`: **reviewed** — included in a context-limited batch <details><summary>Review metadata</summary> - Reviewer: forgejo-ai-review v1 - Model: qwen3.6:35b-a3b-q8_0 - Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md - Commits considered: 2 - Previous automated review: updated - Findings: 1 </details>

nimmo added 1 commit

2026-07-21 21:00:58 +01:00

style: qualify Element Electron override

Build and Push Attic Cache / test (pull_request) Successful in 32s

Details

Build and Push Attic Cache / build (pull_request) Has been skipped

Details

AI pull-request review / review (pull_request) Successful in 3m1s

Details

3e26766698

nimmo merged commit f128b2c665 into main

2026-07-21 21:05:04 +01:00

nimmo referenced this pull request from a commit

2026-07-21 21:05:05 +01:00

Merge pull request 'Use regular unstable for Electra and avoid source Electron builds' (#85) from electra-regular-unstable into main

nimmo deleted branch electra-regular-unstable

2026-07-21 21:05:05 +01:00

No reviewers

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

nimmo/nixos-config!85

No description provided.

Rows
Columns