fix: unify nixpkgs inputs and Firefox ownership

nimmo commented

2026-07-22 13:00:47 +01:00

Owner

Summary

make nixos-hardware follow the root nixpkgs input, removing its stale January channel snapshot from the lock graph
keep Home Manager's Firefox profile configuration while leaving installation to the system-level Firefox package

Validation

nix eval --raw .#nixosConfigurations.electra.config.system.build.toplevel.drvPath

This is evaluation-only; it does not build packages.

## Summary - make nixos-hardware follow the root nixpkgs input, removing its stale January channel snapshot from the lock graph - keep Home Manager's Firefox profile configuration while leaving installation to the system-level Firefox package ## Validation - nix eval --raw .#nixosConfigurations.electra.config.system.build.toplevel.drvPath This is evaluation-only; it does not build packages.

nimmo added 1 commit

2026-07-22 13:00:47 +01:00

fix: unify nixpkgs inputs and Firefox ownership

Build and Push Attic Cache / test (pull_request) Successful in 35s

Details

Build and Push Attic Cache / build (pull_request) Has been skipped

Details

AI pull-request review / review (pull_request) Successful in 2m31s

Details

5a6c218587

nimmo commented

2026-07-22 13:11:02 +01:00

Author

Owner

Automated code review

Reviewed commit: 5a6c218587e59ba6bc389cb25d10baabc26f1b98

Verdict: Requires further work

Resolve the blocking or important findings and investigate failed deterministic checks before merging.

Overall assessment

The PR consolidates flake inputs by adding nixos-hardware.inputs.nixpkgs.follows = "nixpkgs", removing an independent channel snapshot and unifying the nixpkgs revision across the graph. It also updates home/nimmo.nix to set programs.firefox.package = null, delegating browser provisioning to the system level while retaining Home Manager ownership of profiles and extensions. Local validation confirms successful evaluation.

Blocking findings

None.

Important findings

None.

Suggestions

None.

Tests and validation

nix-flake-check: failure
- Raw output: error: Resource temporarily unavailable

Questions

The comment in home/nimmo.nix states that the Firefox package is installed system-wide. Is this system-wide installation explicitly declared in another configuration module within this repository? Verifying its presence ensures the binary remains available for non-server hosts after Home Manager stops managing it.

Review limitations

Review is based solely on the provided diff and human replies. I did not execute nix flake check or inspect the full module import chain to verify system-wide Firefox provisioning across all host configurations.

Diff coverage

flake.lock: reviewed — included in a context-limited batch
flake.nix: reviewed — included in a context-limited batch
home/nimmo.nix: reviewed — included in a context-limited batch

Review metadata

Reviewer: forgejo-ai-review v1
Model: qwen3.6:35b-a3b-q8_0
Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md
Commits considered: 1
Previous automated review: updated
Findings: 0

## Automated code review Reviewed commit: `5a6c218587e59ba6bc389cb25d10baabc26f1b98` ## Verdict: Requires further work Resolve the blocking or important findings and investigate failed deterministic checks before merging. ### Overall assessment The PR consolidates flake inputs by adding `nixos-hardware.inputs.nixpkgs.follows = "nixpkgs"`, removing an independent channel snapshot and unifying the `nixpkgs` revision across the graph. It also updates `home/nimmo.nix` to set `programs.firefox.package = null`, delegating browser provisioning to the system level while retaining Home Manager ownership of profiles and extensions. Local validation confirms successful evaluation. ### Blocking findings None. ### Important findings None. ### Suggestions None. ### Tests and validation - nix-flake-check: **failure** - Raw output: `error: Resource temporarily unavailable ` ### Questions - The comment in `home/nimmo.nix` states that the Firefox package is installed system-wide. Is this system-wide installation explicitly declared in another configuration module within this repository? Verifying its presence ensures the binary remains available for non-server hosts after Home Manager stops managing it. ### Review limitations - Review is based solely on the provided diff and human replies. I did not execute `nix flake check` or inspect the full module import chain to verify system-wide Firefox provisioning across all host configurations. ### Diff coverage - `flake.lock`: **reviewed** — included in a context-limited batch - `flake.nix`: **reviewed** — included in a context-limited batch - `home/nimmo.nix`: **reviewed** — included in a context-limited batch <details><summary>Review metadata</summary> - Reviewer: forgejo-ai-review v1 - Model: qwen3.6:35b-a3b-q8_0 - Guidance loaded: .forgejo/ai-review.md, .forgejo/ai-review.yml, AGENTS.md, README.md - Commits considered: 1 - Previous automated review: updated - Findings: 0 </details>

nimmo commented

2026-07-22 13:45:05 +01:00

Author

Owner

Follow-up: the review's root-input question is based on lock-node renumbering, not a source change. already declared ; this PR adds , so its previously independent January channel snapshot is removed and it uses the existing root input.\n\nI also reran locally after the review. It evaluated the formatter, package, VM test derivation, and all four NixOS configurations successfully. The review runner's result was transient infrastructure contention, not a deterministic flake failure. No follow-up code change is required; commit remains the PR head.

nimmo commented

2026-07-22 13:45:20 +01:00

Author

Owner

Correction to the previous comment (whose inline code formatting was stripped by the command shell):

The root input was already declared as github:NixOS/nixpkgs/nixpkgs-unstable in flake.nix before this PR. This PR adds nixos-hardware.inputs.nixpkgs.follows = "nixpkgs", removing nixos-hardware’s independent January channel snapshot and making it use that existing root input.

I reran: nix flake check --no-build
It evaluated the formatter, package and VM-test derivations, plus all four NixOS configurations, successfully. The review runner’s Resource temporarily unavailable result was transient infrastructure contention, not a deterministic flake failure. No follow-up code change is required; 5a6c218 remains the PR head.

Correction to the previous comment (whose inline code formatting was stripped by the command shell): The root input was already declared as github:NixOS/nixpkgs/nixpkgs-unstable in flake.nix before this PR. This PR adds nixos-hardware.inputs.nixpkgs.follows = "nixpkgs", removing nixos-hardware’s independent January channel snapshot and making it use that existing root input. I reran: nix flake check --no-build It evaluated the formatter, package and VM-test derivations, plus all four NixOS configurations, successfully. The review runner’s Resource temporarily unavailable result was transient infrastructure contention, not a deterministic flake failure. No follow-up code change is required; 5a6c218 remains the PR head.

nimmo merged commit 51ab760bd5 into main

2026-07-22 13:51:39 +01:00

nimmo deleted branch fix-nixpkgs-firefox-cache

2026-07-22 13:51:39 +01:00

nimmo referenced this pull request from a commit

2026-07-22 13:51:39 +01:00

Merge pull request 'fix: unify nixpkgs inputs and Firefox ownership' (#87) from fix-nixpkgs-firefox-cache into main